Fix rendering bug of Markdown Code. #14638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| println(io, "```", code.language) | ||
| # If the code includes a fenced block this will break parsing, | ||
| # so it must be enclosed by a longer ````-sequence. | ||
| n = mapreduce(length, max, matchall(r"`+", code.code)) + 1 |
There was a problem hiding this comment.
Should the regex only match backticks that begin at the start of a line, ie r"^+"m`?
Also, if code.code contains no matches mapreduce would throw
julia> mapreduce(length, max, matchall(r"`+", ""))
ERROR: ArgumentError: reducing over an empty collection is not allowed
in _mapreduce at ./reduce.jl:139
in mapreduce at ./reduce.jl:159
in mapreduce at ./reduce.jl:162
in eval at ./boot.jl:265
since matchall returns a 0-length vector. Is that a valid edge case?
There was a problem hiding this comment.
Ah yes, so it can be:
mapreduce(length, max, 1, matchall(r"^`+"m, code.code))
There was a problem hiding this comment.
mapreduce(length, max, 3, matchall(r"^`+"m, code.code))
? To avoid setting n = 1.
There was a problem hiding this comment.
Yeah, you're right. Though you actually still need the + 1 in there. Have updated.
hayd
force-pushed
the
fix_plain_code
branch
3 times, most recently
from
1cc38cb to
c9a9181
Compare
When a code block included a ```, it would not be rendered correctly.
|
The 64 bit travis error is surely unrelated: |
hayd
added a commit
that referenced
this pull request
Jan 12, 2016
Fix rendering bug of Markdown Code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a code block included a ```, it would not be rendered correctly.
cc @MichaelHatherly